Fix issue resulting in HTTP 200 being returned for request/responses using 100-continue that should actually return 201, 400, 500, etc. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP 1xx's are interim status codes to be followed up by another. Prior to this change, if a response code for 100 Continue was written, any follow up call to WriteHeader was a no-op, and resulted in responses always receiving a 200 OK, even if WriteHeader was a 201, 404, 500, etc.
geofffranks
changed the title
geofffranks
added a commit
to cloudfoundry/routing-release
that referenced
this pull request
May 14, 2024
…continues Needed until urfave/negroni#277 is merged, to resolve #409.
1 task
jrussett
pushed a commit
to cloudfoundry/routing-release
that referenced
this pull request
May 14, 2024
…continues (#410) Needed until urfave/negroni#277 is merged, to resolve #409.
|
@jszwedko would you be able to take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP 1xx's are interim status codes to be followed up by another. Prior to this change, if a response code for 100 Continue was written, any follow up call to WriteHeader was a no-op, and resulted in responses always receiving a 200 OK, even if WriteHeader was a 201, 404, 500, etc.
This fixes the issue seen in cloudfoundry/routing-release#409, which started occurring as of the negroni code change ec1c41c.