Stop command aliases and flag aliases from being suggested in shell completion #1876
Conversation
|
Should I make the same PR but for v3 branch? |
bartekpacia
changed the title
bartekpacia
changed the title
- printCommandSuggestions: omit Command aliases from suggesting - printFlagSuggestions: omit Flag aliases from suggesting - fix tests
bartekpacia
force-pushed
the
v2/fix/completion_aliases
branch
from
0186eff
to
43272e2
Compare
|
+1 This is what I'd expect over the original. |
|
Thanks for the reviews (and for being maintainers of this module!) Should I make the same PR but for v3 branch? |
|
@bartekpacia I agree with @Juneezee . This breaks peoples current expectation of how the completion works. If you want to have this feature it would be better to define a new bool var in Command, something like "DisableAliasInCompletion" which when explicity set to true would show the behaviour that you want. Also note that v2 is in maint and no new features/API/breaking changes are allowed. v3 is the place for this. Unless you have a strong reason to use v2 instead of v3 I would suggest you close this PR and apply the patch in v3. |
|
Understood, thank you for review @dearchap! I'll soon make another PR targeting v3. |
What type of PR is this?
Which issue(s) this PR fixes:
This PR fixes #1875
Release Notes