Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Generic Support For ISCs #1706

Open
wants to merge 1 commit into
base: v2-maint
Choose a base branch
from

Commits on Mar 18, 2023

  1. Better Generic Support

    - Allow generics to be set as their Set() string in the config
    - Allow converting internal ISC types to Generics when:
      - The data used to define the Generic can be expressed in JSON
      - The target Generic implements `FromJson([]byte) error`
      - The source ISC implements `Json(name string) ([]byte, error)`
    - Update existing ISC implementations to also implement
      `Json(name string) ([]byte, error)`
    
    And of course there are tests for the new features.
    danhunsaker committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    f760a89 View commit details
    Browse the repository at this point in the history