Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow string array in WithConnParams #732

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mik-volkov
Copy link

#611
This PR allows multiple parameters to WithConnParams in the form of string slice

		pgdriver.WithConnParams(map[string]interface{}{
			"search_path": []string{"foo", "bar"},
		}),

@vmihailenco
Copy link
Member

This PR assumes that []string{"foo", "bar"} can be appended as is and does not require any quotation which might not be the case.

@mik-volkov
Copy link
Author

Added quotation to parameters processing

@qindj
Copy link

qindj commented Oct 24, 2023

could you please merge this? I met the same issue, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants