Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Logger #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement Logger #7

wants to merge 2 commits into from
+239 −2

Conversation

SevenOfNinePE
Copy link
Collaborator

Bugfix: Fct. plot_channels: Set return value in case of only 1 channel is to plot.

@SevenOfNinePE
Implement Logger
cbbf2f7 
Bugfix: Fct. plot_channels: Set return value in case of only 1 channel is to plot.
@SevenOfNinePE SevenOfNinePE self-assigned this Nov 4, 2024
@SevenOfNinePE SevenOfNinePE linked an issue Nov 4, 2024 that may be closed by this pull request
Implement Logger #6
Open
4 tasks
@gituser789
Copy link
Contributor

Linters have failed.
Run the following commands on your machine to see the errors:

  • ruff check $(git ls-files '*.py')
  • pycodestyle $(git ls-files '*.py')
  • pylint $(git ls-files '*.py')

@gituser789 gituser789 added the enhancement New feature or request label Nov 4, 2024
@gituser789 gituser789 added this to the 0.2.0 milestone Nov 4, 2024
gituser789
gituser789 requested changes Nov 4, 2024
View reviewed changes
pysignalscope/scope.py
if channel_linestyle is not None:
self.channel_linestyle = channel_linestyle
modify_flag = True
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a single pass?

pysignalscope/scope.py
pass

# Log flow control ASA
logging.debug("%s :FlCtl", self.modulename)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i prefer f"" instead of %s to unify the code, as it is better readable.
There are more %s in the rest of the code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gituser789 gituser789 gituser789 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@SevenOfNinePE SevenOfNinePE

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Implement Logger
2 participants
@SevenOfNinePE @gituser789