Dont raise exception on dict input #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XyDrKRulof
requested changes
May 21, 2024
src/gym_electric_motor/utils.py
Outdated
| @@ -2,18 +2,17 @@ | |||
| import numpy as np | |||
|
|
|||
|
|
|||
| # This hacky function stays for now because, all envs use it and refectoring would be a pain TODO: fix this | |||
| # This hacky function stays for now because all envs uses it and refectoring would be a pain | |||
There was a problem hiding this comment.
Can we elaborate on this more? Either remove this comment and raise an issue explaining why this function should be removed and how it is difficult to do so. Otherwise, please make this comment more elaborate (also make it sound more neutral). Thank you
XyDrKRulof
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems described in the email by Darius