Skip to content

Fix Protobuf<4.0 is deprecated, relax dependency #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hoh
Copy link

@hoh hoh commented Mar 10, 2025

The last release was of protobuf <4 was version 3.20.3 in Sept 2022.

Problem

This dependency is not used in the project and causes conflicts in projects using a newer version.

The only reference to protobuf is here, and does not rely on the pinned version.

Proposal

Relax the dependency or remove it completely from pyproject.toml.

Last release was 3.20.3 in Sept 2022.
@danielhanchen
Copy link
Contributor

Hmm I actually can't remember why I had protobuf - I think it was due to sentencepiece

@hoh
Copy link
Author

hoh commented Mar 17, 2025

Can it be removed instead then ?

@miguelamavel
Copy link

this requirement was relaxed in unsloth already #2637. can this be merged here too now?

@yxtay
Copy link

yxtay commented Jul 15, 2025

Is there any reason why protobuf is directly pinned in unsloth-zoo? The only reference in the code is the following, and it is to install an unpinned version of protobuf using pip.

try_execute(f"{pip} install gguf protobuf sentencepiece", **kwargs)

If unsloth-zoo does not depend on protobuf directly, I'd recommend to completely remove specifying it as a dependency and allow downstream dependencies to install only if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants