Typo: SimpleCalc 04-App Architecture #171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating DataContext snippet to MainModel instead of MainViewModel
trydalch
commented
Oct 18, 2024
| [!include[Feeds and Commands](../../Resources/MVUX/Feeds-and-Commands.md)] | ||
|
|
||
| **[Import UI from Figma](xref:Workshop.SimpleCalc.MVUX.XAML.Figma) or [Creating the Layout](xref:Workshop.SimpleCalc.MVUX.XAML.CreatingLayout) | [Next](xref:Workshop.SimpleCalc.MVUX.XAML.Finishing)** | ||
| **[Import UI from Figma](xref:Workshop.SimpleCalc.MVUX.XAML.Figma) or [Creating the Layout](xref:Workshop.SimpleCalc.MVUX.XAML.CreatingLayout) | [Next](xref:Workshop.SimpleCalc.MVUX.XAML.Finishing)** |
Author
There was a problem hiding this comment.
I'm not sure why this is highlighted as a change. I didn't modify it.
|
@agneszitte looked up the changes, but to me as I used mainly mvux in the last time it seems like the typo tryed to be corrected is none because we do instanciate the MainViewModel here in the case not using uno navigator as far as I learned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating DataContext snippet to MainModel instead of MainViewModel
Description (*)
The MVUX SimpleCalculator docs incorrectly said to create a MainViewModel, instead of a MainModel
Fixed Issues (if necessary)
I'm not aware of any open issue.
Screenshots (if necessary)
Contribution checklist (*)