feat: Centralize MSBuild Assets to Directory.Build.props file #1878
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Directory.Build.props file is eitherway provided, but always just the Project tag, so we can also simplify the Analyzer Handling for the User out of the box and centralize this just like the Package Versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The Directory.Build.props file is always provided, but also always only including just the Project tag with some Properties but given case the configuration would add GitHub Actions currently the Assets would always be added in the
.csprojthe Package is used in (unit / UI Tests) which adds unnessesary builderplate code and means work for users that would like to only have to update or change things on one place like we have already with theDirectory.Packages.propsWhat is the new behavior?
We simplify the Assets Definition used by ms build, so the User gets it already out of the box and centrally defined and dont have to change it manually or keep it maintained on multiple places if anything might need to be changed and his solution got larger.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
The future Server Project could also contain a Assets using Package for the OpenApi spec generation and benefit from centralized Setup of the Assets as suggested on this PR:
Internal Issue (If applicable):