Skip to content

Conversation

@Kunal22shah
Copy link
Contributor

GitHub Issue (If applicable): closes https://github.com/unoplatform/uno.themes-private/issues/31

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Kunal22shah Kunal22shah requested a review from kazo0 January 15, 2026 18:21
@Kunal22shah Kunal22shah self-assigned this Jan 15, 2026
@Kunal22shah Kunal22shah marked this pull request as ready for review January 15, 2026 18:21
Copilot AI review requested due to automatic review settings January 15, 2026 18:21
@Kunal22shah Kunal22shah mentioned this pull request Jan 15, 2026
12 tasks
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new "Simple" design system library to the Uno.Themes repository, adding a third design option alongside the existing Material and Cupertino themes. The Simple design system provides a minimalist, neutral aesthetic with comprehensive styling for common UI controls.

Changes:

  • Added complete Simple design system library (Uno.Simple.WinUI) with color palette, fonts, and control styles
  • Integrated Simple theme support into the samples application with dedicated sample pages
  • Created markup extensions library (Uno.Simple.WinUI.Markup) for C# markup support

Reviewed changes

Copilot reviewed 43 out of 44 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/library/Uno.Simple.WinUI/* Core Simple design system library with styles, colors, and theme infrastructure
src/samples/UWP/Uno.Themes.Samples.Shared/* Sample pages and integration for demonstrating Simple controls
src/library/Uno.Simple.WinUI.Markup/* C# markup extensions for Simple theme
Uno.Themes.sln Solution file updated to include new Simple projects
src/library/Uno.Themes/themes-common.props Added InternalsVisibleTo for Simple library

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +11 to +16
<!-- <MaterialColorsV1 xmlns="using:Uno.Material" OverrideSource="ms-appx:///ColorPaletteOverride.xaml" />
<MaterialFonts xmlns="using:Uno.Material" />
<MaterialResourcesV1 xmlns="using:Uno.Material" />
<MaterialTheme xmlns="using:Uno.Material"
ColorOverrideSource="ms-appx:///ColorPaletteOverride.xaml" />
ColorOverrideSource="ms-appx:///ColorPaletteOverride.xaml" /> -->
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Material theme resources are commented out in the samples application. If this is intentional for testing the Simple theme in isolation, it should be documented with a comment explaining why. Otherwise, both themes should be available in the samples app for comparison.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants