Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages/ui): Storybook deploy fix #15252

Merged
merged 14 commits into from
Dec 12, 2024
Merged

fix(packages/ui): Storybook deploy fix #15252

merged 14 commits into from
Dec 12, 2024

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Dec 9, 2024

Description

This PR introduces changes that optimises the deployment script for the ui package

Issues

Fixes #
Refs #15237

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 December 9, 2024 15:17
@cla-bot cla-bot bot added the cla-signed label Dec 9, 2024
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unlock-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:27pm

@0xTxbi 0xTxbi changed the title fix(packages/ui)): Storybook deploy fix fix(packages/ui): Storybook deploy fix Dec 9, 2024
stories: ['../lib/**/*.stories.mdx', '../lib/**/*.stories.@(js|jsx|ts|tsx)'],
addons: ['@storybook/addon-links', '@storybook/addon-essentials'],
staticDirs: ['../public'],
framework: '@storybook/react-vite',
core: {
builder: '@storybook/builder-vite',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@0xTxbi 0xTxbi merged commit e754e99 into master Dec 12, 2024
11 of 12 checks passed
@0xTxbi 0xTxbi deleted the storybook-deploy-fix branch December 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants