Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(packages/ui): Prepare ui package for Vercel deployment #15251

Merged
merged 4 commits into from
Dec 9, 2024
Merged

feature(packages/ui): Prepare ui package for Vercel deployment #15251

merged 4 commits into from
Dec 9, 2024

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Dec 9, 2024

Description

This PR introduces configuration updates to make the UI package compatible with deployment on Vercel.

Issues

Fixes #
Refs #15237

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 December 9, 2024 12:59
@cla-bot cla-bot bot added the cla-signed label Dec 9, 2024
@0xTxbi 0xTxbi marked this pull request as ready for review December 9, 2024 12:59
julien51
julien51 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please add details to the readme with the URL!

@0xTxbi
Copy link
Member Author

0xTxbi commented Dec 9, 2024

LGTM! Please add details to the readme with the URL!

sure thing!

@0xTxbi 0xTxbi merged commit 9227f4f into master Dec 9, 2024
10 checks passed
@0xTxbi 0xTxbi deleted the prepare-storybook-deploy branch December 9, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 julien51 approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xTxbi @julien51