Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulsechain Network Addition #12948

Closed
wants to merge 10 commits into from
Prev Previous commit
Next Next commit
Update pulsechain.ts
JexxaJ authored Nov 7, 2023
commit efd7e8b020e11959f7e0eeff93743ce6d1b0ff5a
4 changes: 2 additions & 2 deletions packages/networks/src/networks/pulsechain.ts
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ import { NetworkConfig } from '@unlock-protocol/types'

export const pulsechain: NetworkConfig = {
chain: 'pulsechain',
description: 'pulsechain mainnet.',
description: 'Pulsechain is a full system state fork of Ethereum mainnet and maintains upstream compatliblity with the Ethereum code base. It provides lower gas costs and 10s block times and is supported by a community that places importance on permissionless protocols.',
explorer: {
name: 'Pulsechain',
urls: {
@@ -32,7 +32,7 @@ export const pulsechain: NetworkConfig = {
previousDeploys: [],
provider: 'https://rpc.unlock-protocol.com/369',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to deploy a provider for this.

publicLockVersionToDeploy: 13,
publicProvider: 'https://scan.pulsechain.com',
publicProvider: 'https://rpc.pulsechain.com',
startBlock: 2247300,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TK

// Graph can be found at https://graph.pulsechain.com/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not a standard https://thegraph.com/ setup you need to send us docs on how to set it up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try and get some more info for you on this side of things. Is this a nice to have or required?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for the frontend to work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so there is a community graph node that can be used. I have spoken to the team running this and they have advised while there is no end-user UI at present if you are able to provide the subgraph code you want hosted they will run this up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this is too complex for us to maintain so until there is a proper graph deployment we won't merge this PR.

subgraph: {