fix: Resolve generating multiple thumbnails in Dolphin#127
Open
troxor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts
lib.rsso that the graphics context is initialized once and not for every thumbnail.I tested on Arch with KDE/Dolphin running on hardware, and on openSUSE Leap 16.0 with GNOME/Nautilus in a VM.
On the VM, I had to set
LIBGL_ALWAYS_SOFTWARE=1and install libOSMesa8 to get output. Otherwise,~/.cache/thumbnails/failwould accumulate failed thumbnails.Thanks to @twelho in the comment here for the clues.
Fixes stl-thumb-kde#5