Add macOS support#126
Open
diminox-kullwinder wants to merge 1 commit into
Open
Conversation
- Add create_headless_display for target_os macos - Update GLSL shaders to version 150 (required for macOS core profile) - Change attribute/varying to in/out, texture2D to texture - Tested on macOS 14.x Sonoma with Apple Silicon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds native macOS support to stl-thumb, enabling headless thumbnail rendering on Apple systems.
Changes
1. macOS headless display (
src/lib.rs)Added
create_headless_displayimplementation fortarget_os = "macos"using the same pattern as Windows (simpler than Linux's multi-fallback approach).2. GLSL shader updates (all shaders)
macOS's OpenGL core profile requires GLSL 150+. Updated all shaders:
#version 120→#version 150attribute→invarying→out/intexture2D()→texture()gl_FragColor→ explicitout vec4 fragColorThese changes are backwards compatible with Linux/Windows as GLSL 150 is widely supported.
Testing
Tested on macOS 14.x (Sonoma) with Intel x86_64:
Notes