fix: generate safe imports code using knitwork (#24)

package.json

@@ -48,6 +48,7 @@
  "test:types": "tsc --noEmit --skipLibCheck"
  },
  "dependencies": {
+ "knitwork": "^1.0.0",
  "magic-string": "^0.30.8",
  "mlly": "^1.6.1",
  "pathe": "^1.1.2",

src/plugin/runtime.ts

@@ -1,4 +1,10 @@
 import { readPackageJSON } from "pkg-types";
+import {
+ genSafeVariableName,
+ genObjectFromRaw,
+ genString,
+ genImport,
+} from "knitwork";
 import {
  UMWASM_HELPERS_ID,
  UNWASM_EXTERNAL_PREFIX,
@@ -186,30 +192,35 @@ export async function getWasmImports(
  // Try to resolve from nearest package.json
  const pkgJSON = await readPackageJSON(asset.id);
 
- let code = "const _imports = {";
-
  let resolved = true;
 
+ const imports: string[] = [];
+ const importsObject: Record<string, Record<string, string>> = {};
+
  for (const moduleName of importNames) {
  const importNames = asset.imports[moduleName];
  const pkgImport =
  pkgJSON.imports?.[moduleName] || pkgJSON.imports?.[`#${moduleName}`];
 
+ const importName = "_imports_" + genSafeVariableName(moduleName);
+
  if (pkgImport) {
- code = `import * as _imports_${moduleName} from "${pkgImport}";\n${code}`;
+ imports.push(genImport(pkgImport, { name: "*", as: importName }));
  } else {
  resolved = false;
  }
- code += `\n ${moduleName}: {`;
- for (const name of importNames) {
- code += pkgImport
- ? `\n ${name}: _imports_${moduleName}.${name},\n`
- : `\n ${name}: () => { throw new Error("\`${moduleName}.${name}\` is not provided!")},\n`;
- }
- code += " },\n";
+
+ importsObject[moduleName] = Object.fromEntries(
+ importNames.map((name) => [
+ name,
+ pkgImport
+ ? `${importName}[${genString(name)}]`
+ : `() => { throw new Error(${genString(moduleName + "." + importName)} + " is not provided!")}`,
+ ]),
+ );
  }
 
- code += "};\n";
+ const code = `${imports.join("\n")}\n\nconst _imports = ${genObjectFromRaw(importsObject)}`;
 
  return {
  code,