Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/highlight code #90

Closed
wants to merge 1 commit into from
Closed

feat/highlight code #90

wants to merge 1 commit into from

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 4, 2024

[wip]

Copy link

cloudflare-pages bot commented Mar 4, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3a5fe7c
Status: ✅  Deploy successful!
Preview URL: https://53591d29.undocs.pages.dev
Branch Preview URL: https://feat-highlight-code.undocs.pages.dev

View logs

@cpreston321
Copy link
Member

cpreston321 commented Mar 4, 2024

@pi0 this would work if the Shiki just return the generate code with pre tag vs with div or span. That is what the ProseCode expects.

If you see it adds an extra div.

CleanShot 2024-03-04 at 13 00 17@2x

@pi0
Copy link
Member Author

pi0 commented Mar 4, 2024

Yes just talking with @benjamincanac and he mentioned it is hard to support without unwrap.

I guess will endup with a dirty transform in nuxt-shiki to unwrap…

@pi0
Copy link
Member Author

pi0 commented Mar 6, 2024

Okay we supprot unwrap and have a working poc but just noticed the blocks are single colored 😆 (sometimes I feel trapped with over engineering)

image

@pi0 pi0 closed this Mar 6, 2024
@pi0 pi0 deleted the feat/highlight-code branch March 6, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants