feat: add loading indicator #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Mar 4, 2024
| @@ -20,6 +20,7 @@ provide('navigation', navigation) | |||
| </script> | |||
|
|
|||
| <template> | |||
| <NuxtLoadingIndicator color="rgb(252,211,77)" /> | |||
There was a problem hiding this comment.
We might inherit color from theme. But lets iterate 👍🏼
There was a problem hiding this comment.
Right that would be best. For some reason couldn't set it using color and with style didn't work either... though didn't try !important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#77
❓ Type of change
📚 Description
Just added a loading indicator. Think this will make UX much better - definilty until hover issue is fixed (#69) - and nuxt ui is "sped up" - since on mobile and sometimes on desktop, you literally don't know if your click routed.
BTW
Wasnt able to pass bg color tailwind class... not sure why.. prob because of !important
📝 Checklist