fix: consider max depth when multiple placeholders are candidate #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #95 (context: unjs/nitro#2310)
The issue is original implementation considered there is one placeholder candidate on each level of tree (cached into
placeholderChildNode). If there is more than one, we need to find the right candidate.This PR fixes issue by assigning max depth to nodes when inserting and consider it when choosing the right candidate (it should have same remaining length of incoming request path)
(honestly this implementation is hacky, but for v1 we have no choice until fully rewrite in v2)