Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matcher): avoid prefix overlap for wildcards #92

Merged
merged 2 commits into from Mar 8, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 8, 2024

πŸ”— Linked issue

resolves #70

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR solves an issue with matcher that checked the segment without / prefix in wildcards.

/foo/** should match /foo/, /foo/bar and /foo but not /foobar

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit 9889689 into v1 Mar 8, 2024
1 check failed
@pi0 pi0 deleted the fix/prefix-overlap branch March 8, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard matcher overlaps prefix
1 participant