Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netlify-v2): netlify not finding getGeneratorString #2425

Closed
wants to merge 3 commits into from

Conversation

Rigo-m
Copy link
Contributor

@Rigo-m Rigo-m commented May 9, 2024

πŸ”— Linked issue

#2426

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Publishing to netlify, the functions fails with this error: getGeneratorString is not defined

@serhalp could you take a quick look?

Reproduction link in linked issue

https://github.com/Rigo-m/netlify-v2-repro/tree/patch-fix this branch contains a custom preset with the proposed fix
and it displays correctly in netlify https://patch-fix--netlify-v2-nitro.netlify.app/

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Contributor

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@pi0
Copy link
Member

pi0 commented May 16, 2024

Thanks ❀️ The fix is included in #2446

@pi0 pi0 closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants