Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(externals): skip resolving virtual ids start with \0 #2321

Merged
merged 2 commits into from Mar 27, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 27, 2024

πŸ”— Linked issue

analogjs/analog#969 (comment)

Reproduction: https://github.com/brandonroberts/analog-nitro-295

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR fixes an issue revealed by #2289.

After calling (rollup) this.resolve, the result might be a virtual import starting with \0 which we shouldn't attempt to resolve using build-in ESM resolution (mlly).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix(externals): skip resolving virtual ids fix(externals): skip resolving virtual ids start wht \0 Mar 27, 2024
@pi0 pi0 changed the title fix(externals): skip resolving virtual ids start wht \0 fix(externals): skip resolving virtual ids start with \0 Mar 27, 2024
@pi0 pi0 merged commit 873c89e into main Mar 27, 2024
5 checks passed
@pi0 pi0 deleted the fix/externals-virtual branch March 27, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant