Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prerender): call nitroApp close hook when done prerendering #2287

Merged
merged 1 commit into from Mar 21, 2024
Merged

fix(prerender): call nitroApp close hook when done prerendering #2287

merged 1 commit into from Mar 21, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Mar 21, 2024 •
edited

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Discovered while investigating original reproduction in nuxt/cli#193.

Nitro prerenderer was never calling nitro 'close' hook which meant there was no way for runtime code to clean up after itself.

resolves nuxt/cli#193

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working prerender labels Mar 21, 2024
@danielroe danielroe requested a review from pi0 March 21, 2024 16:43
@danielroe danielroe self-assigned this Mar 21, 2024
@danielroe danielroe mentioned this pull request Mar 21, 2024
Closed
pi0
pi0 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

@pi0 pi0 merged commit 5184e45 into main Mar 21, 2024
5 checks passed
@pi0 pi0 deleted the fix/close-prerenderer branch March 21, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working prerender
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force close process after build / prepare commands
2 participants
@danielroe @pi0