fix: make scheduledTasks types consistent #2284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Mar 21, 2024
| @@ -128,6 +128,12 @@ export async function createNitro( | |||
| nitro.options.virtual["#internal/nitro/virtual/tasks"] = () => { | |||
| const _scheduledTasks = Object.entries(nitro.options.scheduledTasks || {}) | |||
| .map(([cron, _tasks]) => { | |||
| if (!Array.isArray(_tasks)) { | |||
| nitro.logger.warn( | |||
There was a problem hiding this comment.
I still like to support non array format.
|
Yes of course ! I don't mind reverting my changes at all I explained it in the PR. However, there is still something that could be fixed, which is the default empty object for |
|
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #2283, related to nuxt/devtools#626
❓ Type of change
📚 Description
scheduledTasksdefault to{}instead of undefined -> Should be fixed to match the typescheduledTaskstype consistent with the array notation -> I can revert if unwanted.📝 Checklist