Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server-assets): mark yaml, json, json5 and csv as text #2229

Merged
merged 1 commit into from Mar 8, 2024
Merged

fix(server-assets): mark yaml, json, json5 and csv as text #2229

merged 1 commit into from Mar 8, 2024

Conversation

manniL
Copy link
Member

@manniL manniL commented Mar 7, 2024

🔗 Linked issue

Resolves #2217

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds more extensions which are definitely not binary files.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title chore: add more extensions excluded from binary conversion fix: exclude more extensions from binary conversion Mar 8, 2024
@pi0 pi0 changed the title fix: exclude more extensions from binary conversion fix(server-assets): mark yaml, json, json5 and csv as text Mar 8, 2024
pi0
pi0 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pi0 pi0 merged commit c4b619c into main Mar 8, 2024
5 checks passed
@pi0 pi0 deleted the manniL-patch-1 branch March 8, 2024 10:34
@dargmuesli dargmuesli mentioned this pull request Mar 9, 2024
Closed
@pi0 pi0 mentioned this pull request Mar 10, 2024
Merged
@BobbieGoede BobbieGoede mentioned this pull request Mar 17, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON file content returned as binary instead of json if sent as nested response
3 participants
@manniL @pi0 @danielroe