feat(isValidNodeImport): support stripComments option

[huang-julien]

🔗 Linked issue

huang-julien/nitro-applicationinsights#58
unjs/nitro#2308

❓ Type of change

• 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

hi 👋 this PR adds a stripCommentsFromCode option for isValidNodeImport.

I think the stripComments option from detectSyntax was made to avoid breaking anything in the ecosystem.

The issue lies in the non-legacy externals plugin in nitro which tries to inline applicationinsights import when it shouldn't due to applicationinsights having cjs syntax and esm syntax within its comments.

The goal of the PR is to open another PR in nitro to add a stripCommentsFromCode option for the external rollup plugin.

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (226a47b) to head (b39f7cf).
Report is 20 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   88.04%   87.34%   -0.71%     
==========================================
  Files           8        8              
  Lines        1062     1098      +36     
  Branches      188      200      +12     
==========================================
+ Hits          935      959      +24     
- Misses        127      139      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[huang-julien]

BTW any idea of a safer way to strip comments from a code so we can enable it by default in hasESMSyntax and hasCJSSyntax ?

[pi0]

Thanks for the PR. I think the addition of this option is good for me but I probably won't enable it in any higher layers like Nitro because it can cause other regressions unless there are more examples like applicationinsights that are currently broken.

BTW any idea of a safer way to strip comments from a code so we can enable it by default in hasESMSyntax and hasCJSSyntax ?

#219 (in next major version)