-
-
Notifications
You must be signed in to change notification settings - Fork 41
feat(fontless): expose preload fonts to server runtime #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hi-ogawa
wants to merge
34
commits into
unjs:main
Choose a base branch
from
hi-ogawa:09-27-feat_fontless_expose_preload_fonts_via_fontless_runtime_
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(fontless): expose preload fonts to server runtime #651
hi-ogawa
wants to merge
34
commits into
unjs:main
from
hi-ogawa:09-27-feat_fontless_expose_preload_fonts_via_fontless_runtime_
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9e3788e.
❌ Deploy Preview for fontless failed.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
- Coverage 53.40% 48.70% -4.71%
==========================================
Files 11 12 +1
Lines 734 809 +75
Branches 93 94 +1
==========================================
+ Hits 392 394 +2
- Misses 342 415 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hi-ogawa
commented
Sep 27, 2025
…_fontless_runtime_
…_fontless_runtime_
commit: |
2 tasks
fontless/runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the list of font urls to be preloaded via virtual module
fontless/runtime. This approach assumes the css file is transformed on server environment.(Note that, until #655 lands, the preloaded font isn't the one actually used, so it's not effective yet.)
TODO
packages/fontless/examples/react-router-app)examples/sveltekit-appand removedsvelte-appqwikVite({ disableFontPreload: true })transformIndexHtml, so no manual head setup is necessary.