feat(fontless): support for local file urls from font providers #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, fonts installed into node_modules and resolved via `import.meta.resolve`
✅ Deploy Preview for fontless ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 54.68% 54.15% -0.54%
==========================================
Files 11 11
Lines 640 650 +10
Branches 81 81
==========================================
+ Hits 350 352 +2
- Misses 290 298 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielroe
reviewed
Sep 10, 2025
| dev: boolean | ||
| renderedFontURLs: Map<string, string> | ||
| assetsBaseURL: string | ||
| devFilesystemURL?: string |
There was a problem hiding this comment.
why do we need to pass this? can't we just directly convert file:/// url into a path?
There was a problem hiding this comment.
From my testing, I couldn't get vite to convert url(file:///...) into url(/@fs/...) in css files. Plus I had to account for a custom base like /_nuxt/@fs/....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, fonts installed into node_modules and resolved via
import.meta.resolveThis is a required change to support #542