feat(connectors): mysql2 support #86
Open
+225
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arashsheyda
commented
Apr 19, 2024
| return _connection; | ||
| } | ||
|
|
||
| _connection = await mysql.createConnection({ |
There was a problem hiding this comment.
I wan't sure if we want to have some options as default, for example we can set the host to localhost or password to ""...
There was a problem hiding this comment.
Would be nice to default to root@localhost:3306 but unsure how useful in practice :)
There was a problem hiding this comment.
yes, or we can set root@localhost:3306 to default only in dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
related to #32
❓ Type of change
📚 Description
this PR adds support for
mysqlconnector usingmysql2+ an example ofmysql(also I'm sorry in advanced if I over stepped, I was checking this fantastic module and couldn't resist trying)📝 Checklist