Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(postgres): throw better error on connection fail #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ToBinio
Copy link

@ToBinio ToBinio commented Mar 29, 2024

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

currently, if no connection can be established the error simply says

ECONNREFUSED: Failed to connect

When using db0 in e.g. Nitro this does not tell you a lot.
With this PR the message looks like this:

ECONNREFUSED: Failed to connect - could not connect to Postgres DB at ""

this clearly tells you that something is wrong with your postgres db

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Note

currently, the connector in the postgresql.ts is called sqliteConnector. Which I don't think it should. If you agree let me know and I will quickly create a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant