Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connectors): update import to work with esm #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amandesai01
Copy link

πŸ”— Linked issue

Resolves #62

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Updated import statement for "pg" so that is works well with *.mjs files.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@fsyntax
Copy link

fsyntax commented Apr 6, 2024

May I ask when this PR is going to get merged?

@amandesai01
Copy link
Author

can we merge this? need this in a project.

@pi0
Copy link
Member

pi0 commented Apr 24, 2024

sorry for delay but i need further testing to see either prefer this or import * as syntax (i understand it fixes nitro builds)

in the meantime i suggest to use pnpm patch.

@BlueBazze
Copy link

pi0 you have any updates or timeline for when you will look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres connector: The requested module 'pg' does not provide an export named 'Client'
4 participants