feat: add usage line for version #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Oct 11, 2023
Barbapapazes
commented
Oct 13, 2023
|
I've updated my PR.
|
Barbapapazes
commented
Dec 13, 2023
| @@ -50,7 +51,15 @@ export async function runCommand<T extends ArgsDef = ArgsDef>( | |||
| ); | |||
| } | |||
| const subCommand = await resolveValue(subCommands[subCommandName]); | |||
| if (subCommand) { | |||
| // Same behavior as for runMain (see src/main.ts) | |||
| if (opts.rawArgs.includes("--version")) { | |||
There was a problem hiding this comment.
Maybe, I should move it to another PR.
and should I create a function to avoid duplication with https://github.com/unjs/citty/blob/1cb60fe5b5aa7be64206e8d865b847adafae6549/src/main.ts#L22C7-L22C7 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Add usage line to tell users how to get the version of the CLI.
📝 Checklist