Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add usage section #70

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

docs: add usage section #70

wants to merge 6 commits into from

Conversation

Barbapapazes
Copy link
Member

@Barbapapazes Barbapapazes commented Sep 12, 2023

πŸ”— Linked issue

fix partially #62

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR add a usage section to the README.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Barbapapazes Barbapapazes added the documentation Improvements or additions to documentation label Sep 12, 2023
@Barbapapazes Barbapapazes self-assigned this Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #70 (26a44f2) into main (f4c4447) will not change coverage.
The diff coverage is n/a.

❗ Current head 26a44f2 differs from pull request most recent head 99a43fc. Consider uploading reports for the commit 99a43fc to get more accurate results

@@    Coverage Diff     @@
##   main   #70   +/-   ##
==========================
==========================

@Barbapapazes Barbapapazes mentioned this pull request Sep 12, 2023
1 task
Copy link

@jd-solanki jd-solanki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed docs. I have reviewed as per your comment and assume we need to write the extension while executing the script. Feel free to ignore comments if aren't relevant.

Thanks again πŸ˜‡

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
```

You're ready to publish your CLI app to npm!

## Utils

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename it to API and add more stuff like what other "type" are available for commands and explain default & required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you refer to the args object @jd-solanki from defineCommand?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes args's type property.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good idea! I will add a section about it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Barbapapazes
Copy link
Member Author

Maybe, I could add that positional arguments are required by default, not if there is a default value.

@Barbapapazes
Copy link
Member Author

Barbapapazes commented Sep 13, 2023

related to #73

@DanielRivers
Copy link

Love these updates! answers most of my questions I had. Merging this will help so many others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants