Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support negativeDescription for args #40

Merged
merged 5 commits into from Mar 18, 2024

Conversation

zuixinwang
Copy link
Contributor

close #39

@zuixinwang zuixinwang closed this Jun 12, 2023
@pi0
Copy link
Member

pi0 commented Sep 9, 2023

@zuixinwang Any reason closed this? Seems a nice idea with negativeDescription.

One relevant usecase https://github.com/nuxt/cli/blob/132024d5dfda9a24a917fe9d075812f54e0a561b/src/commands/dev.ts#L44

@pi0 pi0 reopened this Sep 9, 2023
@pi0 pi0 changed the title fix: semantic does not match description feat: support negativeDescription for args Sep 9, 2023
@zuixinwang
Copy link
Contributor Author

At first, I thought there would be a better way, so I closed this PR, but I haven't come up with a better way yet. If you think this PR is useful, I will continue to do so 😃 @pi0

@zuixinwang
Copy link
Contributor Author

I merged the code already; this PR could be merged now. 😃 @pi0

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@2a3b7d3). Click here to learn what that means.

❗ Current head 301e439 differs from pull request most recent head b67842b. Consider uploading reports for the commit b67842b to get more accurate results

Files Patch % Lines
src/usage.ts 0.00% 5 Missing ⚠️
src/types.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main     #40   +/-   ##
======================================
  Coverage        ?   4.46%           
======================================
  Files           ?      13           
  Lines           ?     919           
  Branches        ?      26           
======================================
  Hits            ?      41           
  Misses          ?     866           
  Partials        ?      12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for all delays!

@pi0 pi0 merged commit 8995534 into unjs:main Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--flag with a default value of true does not match the description
2 participants