Skip to content

Fix token fee on non exist account #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2021
Merged

Fix token fee on non exist account #34

merged 2 commits into from
Dec 27, 2021

Conversation

realelonmusk102
Copy link
Member

@elonkusk please review

@realelonmusk102 realelonmusk102 added the enhancement New feature or request label Dec 27, 2021
@realelonmusk102
Copy link
Member Author

On testnet:

  • transfer 1000000 tokens SSI from UinLtqgPm9waBdUSVAAzRR6pfBzfQNC4c2 to Uh2R7ahQoE5YJDZiM3wc57JRoQmS4xD9Xk

  • before transfer:
    wallet> GetBalance GetAccount with hashed address --> 44e4257594e51b856d87428771a1a9ccdcab8bf5cb, plain text --> UinLtqgPm9waBdUSVAAzRR6pfBzfQNC4c2 Balance = 993887989093350
    wallet> ListTokenPool ssi -1 -1 { "page_size": 20, "total": 1, "tokens": [ { "owner_address": "44e4257594e51b856d87428771a1a9ccdcab8bf5cb", "name": "SSI", "abbr": "ssi", "max_supply": 1000000000, "total_supply": 500000000, "start_time": 1640347986000, "end_time": 2271067986000, "description": "desc", "url": "url", "fee": 10, "extra_fee_rate": 1, "fee_pool": 999999996316, "latest_operation_time": 1640598642000, "lot": 1000, "fee_pool_origin": 1000000000000, "exch_unx_num": 1000000, "exch_num": 1000, "critical_update_time": 1640362971000 } ] }

  • after transfer:
    wallet> GetBalance GetAccount with hashed address --> 44e4257594e51b856d87428771a1a9ccdcab8bf5cb, plain text --> UinLtqgPm9waBdUSVAAzRR6pfBzfQNC4c2 Balance = 993887989092350
    wallet> ListTokenPool ssi -1 -1 { "page_size": 20, "total": 1, "tokens": [ { "owner_address": "44e4257594e51b856d87428771a1a9ccdcab8bf5cb", "name": "SSI", "abbr": "ssi", "max_supply": 1000000000, "total_supply": 500000000, "start_time": 1640347986000, "end_time": 2271067986000, "description": "desc", "url": "url", "fee": 10, "extra_fee_rate": 1, "fee_pool": 999999996316, "latest_operation_time": 1640602410000, "lot": 1000, "fee_pool_origin": 1000000000000, "exch_unx_num": 1000000, "exch_num": 1000, "critical_update_time": 1640362971000 } ] }

PASSED.

@elonkusk elonkusk merged commit 377cf93 into master Dec 27, 2021
@elonkusk elonkusk linked an issue Dec 27, 2021 that may be closed by this pull request
URC30 should charge "create new account" fee on owner account instead of token pool when transfer token to non-exist account #33
Closed
@elonkusk elonkusk deleted the fixTokenFeeOnNonExistAccount branch February 24, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elonkusk elonkusk elonkusk approved these changes

Assignees

@elonkusk elonkusk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URC30 should charge "create new account" fee on owner account instead of token pool when transfer token to non-exist account
2 participants
@realelonmusk102 @elonkusk