-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix end times for historical senators #756
base: main
Are you sure you want to change the base?
Conversation
It looks like the failing checks have nothing to do with this patch. Some new members of congress don't have URL's associated with them. [EDIT: I fixed these errors with a subsequent commit. It's not clear to me how they were committed by someone else if they were failing checks, though.] Still more errors. I think I'll leave them for others to fix up. |
I merged master into the branch and reverted two errors, but there are still failures that need to be resolved:
We sometimes have this problem when legislators never actually served in Congress because they were appointed/elected after the end of the last session, and our practice has been to delete those legislators from our database. That might be the same in some of these cases. Or they may be data errors. |
These end times are off per the Biographical Directory for the United States Congress. FWIW, I found this by cross-checking this data against what's been uploaded to Wikidata.
Regards,
-Doug