Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix end times for historical senators #756

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gitonthescene
Copy link

These end times are off per the Biographical Directory for the United States Congress. FWIW, I found this by cross-checking this data against what's been uploaded to Wikidata.

Regards,
-Doug

@gitonthescene
Copy link
Author

gitonthescene commented Jan 19, 2021

It looks like the failing checks have nothing to do with this patch. Some new members of congress don't have URL's associated with them.

[EDIT: I fixed these errors with a subsequent commit. It's not clear to me how they were committed by someone else if they were failing checks, though.]

Still more errors. I think I'll leave them for others to fix up.

@JoshData
Copy link
Member

This probably overlaps with #475. While #475 has conflicts and can't be merged in its current form, it does add metadata about the reason for the term end, which is nice. But it might be best if we just merge this PR and close #475.

@bycoffe
Copy link
Contributor

bycoffe commented Jan 20, 2021

This may overlap some with #475 but doesn't cover all the changes from that one. There is a CSV in the first comment on #475 that could be used to change the end dates in this PR.

@JoshData
Copy link
Member

JoshData commented Mar 7, 2021

I merged master into the branch and reverted two errors, but there are still failures that need to be resolved:

legislators-historical.yaml:S000682:terms[0](1847-12-06 to 1847-03-03): Term has end before start.
legislators-historical.yaml:W000285:terms[0](1855-12-03 to 1855-03-03): Term has end before start.
legislators-historical.yaml:N000162:terms[0](1857-12-07 to 1857-03-03): Term has end before start.
legislators-historical.yaml:S000526:terms[0](1859-12-05 to 1859-03-04): Term has end before start.
legislators-historical.yaml:W000072:terms[0](1863-12-07 to 1863-03-04): Term has end before start.
legislators-historical.yaml:T000004:terms[0](1883-12-03 to 1883-03-03): Term has end before start.
legislators-historical.yaml:T000432:terms[0](1863-12-07 to 1863-03-03): Term has end before start.
legislators-historical.yaml:H000457:terms[0](1913-04-07 to 1913-01-29): Term has end before start.
legislators-historical.yaml:J000196:terms[0](1913-04-07 to 1913-01-29): Term has end before start.
legislators-historical.yaml:K000023:terms[0](1913-04-07 to 1913-03-03): Term has end before start.
legislators-historical.yaml:W000232:terms[0](1913-04-07 to 1913-03-03): Term has end before start.
legislators-historical.yaml:M001069:terms[0](1907-12-02 to 1907-03-03): Term has end before start.
legislators-historical.yaml:E000109:terms[0](1911-04-04 to 1911-01-31): Term has end before start.

We sometimes have this problem when legislators never actually served in Congress because they were appointed/elected after the end of the last session, and our practice has been to delete those legislators from our database. That might be the same in some of these cases. Or they may be data errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants