Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execution reverted by new coin (even after liquidity added) #350

Open
drone4 opened this issue Oct 13, 2023 · 2 comments
Open

execution reverted by new coin (even after liquidity added) #350

drone4 opened this issue Oct 13, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@drone4
Copy link

drone4 commented Oct 13, 2023

Hi,

By relatively new coins execution always reverted, if no yet liquidity, then no transaction, if liquidity exists it transact, deduct fee but fail.
Even with 0.9 slippage and 1.5current fee, why?
https://etherscan.io/tx/0x1ba2897733c8aacecad59593dd66ed333156645cb1c5d604a45524c9de34f91b
version = 2
provider = "https://mainnet.infura.io/v3/myinfura"
eth = "0x0000000000000000000000000000000000000000"
uniswap = Uniswap(address=address, private_key=private_key, version=version, provider=provider)
uniswap.make_trade(eth, coin, 1
10**16, slippage=0.9, fee=current_gas_price*1.5)
Thanks

@drone4 drone4 added the bug Something isn't working label Oct 13, 2023
@liquid-8
Copy link
Member

The fee param doesn't (and shouldn't) work for V2. By the way, you misinterpret its meaning. However, this error doesn't occur for other tokens. This particular token was likely drained ~two weeks ago, so I can't reproduce it at the moment.

@drone4
Copy link
Author

drone4 commented Oct 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants