New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More helpful error messages for `ContractLogicError: execution reverted` #356

Open

ErikBjare opened this issue Nov 1, 2023 · 0 comments

Labels

Member

ErikBjare commented Nov 1, 2023 •

edited

Seems like one of the most commonly reported issue is about passing wrong params:

I suppose these happen if any of (version, fee, token0, token1) are wrong.

It might be helpful to catch these exceptions and re-raise them with more helpful error messages, as I wrote here: #355 (comment)

We might also want to remove the 0.3% assumption and just raise an exception if not set for V3: #355 (comment)

ErikBjare added the enhancement label

ErikBjare mentioned this issue

Find the optimal trade route (approximately) #93

Open

antibagr mentioned this issue

fix: Make fee a required argument with Uniswap V3 #358

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment