use pathlib consequently to avoid incorrect filepaths #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Triggered from #166 by @trondth. Checking if we can fast forward Target branch ( commit 64ac150883fed6be3170ead6015942ac67c0481a (HEAD -> master, tag: v3.7.3, origin/master, origin/HEAD)
Author: Trond Thorbjørnsen <[email protected]>
Date: Fri Feb 7 10:25:09 2025 +0100
use path from page in file_api_url, when page is not emptyPull request ( commit 42135cd38ff58b11c807341e4cd4a879cfae4ac2 (pull_request/fix_filepaths)
Author: Trond Thorbjørnsen <[email protected]>
Date: Mon Feb 10 10:35:53 2025 +0100
use pathlib consequently to avoid incorrect filepathsIt is possible to fast forward |
leondutoit
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In upload-sync, listing local files in subdirs added an extra slash. This lead to deleting files in upload dir every second time filesync ran. This fix makes use of pathlib similar to previous pr addressing remote files.
This pr also uses switches to using pathlib for other paths found by a simple search in the code base.