-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare support for Python3.12 #1897
Conversation
7d46a46
to
9aacc88
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1897 +/- ##
==========================================
- Coverage 94.28% 93.37% -0.91%
==========================================
Files 91 121 +30
Lines 7013 9365 +2352
==========================================
+ Hits 6612 8745 +2133
- Misses 401 620 +219 ☔ View full report in Codecov by Sentry. |
thanks @g-as ! been wanting to do this for a while, thanks for taking the initiative on this.
We can add exceptions in the CI workflow to only run pyspark on 3.12 for pyspark 4.0 |
8f1ead8
to
2fc6f2f
Compare
Hi @cosmicBboy! Excluded I ignored the rest of the pylint warnings so linters should pass (and thus tests should run). I'll let you decide on how you want to address those. |
Hi @cosmicBboy, as you've seen, the linting workflow fails for I think it is related to this. I thus added |
f71532f
to
816ea40
Compare
Hi @cosmicBboy I also added ![]() Hopefully everything will run now. |
Signed-off-by: Guillaume Andreu Sabater <[email protected]>
Signed-off-by: Guillaume Andreu Sabater <[email protected]>
Signed-off-by: Guillaume Andreu Sabater <[email protected]>
Signed-off-by: Guillaume Andreu Sabater <[email protected]>
Signed-off-by: Guillaume Andreu Sabater <[email protected]>
…d addressing Signed-off-by: Guillaume Andreu Sabater <[email protected]>
…ce it's no longer installed by default with python 3.12 Signed-off-by: Guillaume Andreu Sabater <[email protected]>
it is required in noxfile and not automatically provided by python >= 3.12 Signed-off-by: Guillaume Andreu Sabater <[email protected]>
typing_extensions is currently required by all python versions Signed-off-by: Guillaume Andreu Sabater <[email protected]>
Signed-off-by: Guillaume Andreu Sabater <[email protected]>
e702c4a
to
82c81de
Compare
Yay \o/ What do you want to do about the coverage? |
The coverage on this project has consistently been finicky, will address that in a seperate PR. In the mean time let's go ahead and merge this. |
Thanks for the contribution @g-as ! and congrats on your first PR to pandera 🚀 |
Thanks! Are you interested in me adding 3.13 support? Removing 3.8? |
@g-as thanks for the effort! Re: 3.8, let's go ahead and sunset 3.8 (since it's eol'd for a few months now) Re: 3.13+ support, 3.13 and 3.14 has introduced breaking changes to runtime type checkers. For context, see:
Besides being an entertaining read, it does provide a path forward for what library maintainers will have to do to address the breaking changes. Would you mind opening tickets for supporting 3.13 and 3.14? |
pylint doesn't work becausev2.17.3
won't install on 3.12updated pylint to 3.3, I ignored some warnings, and left some others that need proper addressingpossibly-used-before-assignment
) in situ.distutils
. But besides that, it works. As suggested, I excluded3.12
xpyspark
from the matrix.