Add Unikraft files for TIFF #1
Conversation
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Esteban Martinez <[email protected]>
Signed-off-by: Esteban Martinez <[email protected]>
There was a problem hiding this comment.
Everything is okay.
Reviewed-by: Andrei Mutu [email protected]
Signed-off-by: Razvan Deaconescu <[email protected]>
| # Run ./configure | ||
| $(LIBTIFF_EXTRACTED)/config.status: $(LIBTIFF_BUILD)/.origin | ||
| $(call verbose_cmd,CONFIG,libtiff: $(notdir $@), \ | ||
| cd $(LIBTIFF_EXTRACTED) && ./configure) | ||
|
|
||
| LIBTIFF_PREPARED_DEPS = \ | ||
| $(LIBTIFF_EXTRACTED)/config.status \ | ||
|
|
||
| $(LIBTIFF_BUILD)/.prepared: $(LIBTIFF_PREPARED_DEPS) |
There was a problem hiding this comment.
These step needs to be removed. What is required from the configure step are the libtiff/tiffconf.h and libtiff/tif_config.h files which need to be explicitly created and placed within a top-level include/ directory of this repo. The directory and corresponding header file should be referenced via LIBTIFF_COMMON_INCLUDES. It's options need be checked and must correspond with what is compatible with Unikraft.
| @@ -0,0 +1,12 @@ | |||
| menuconfig LIBTIFF | |||
| bool "libtiff - Tagged Image File Format " | |||
There was a problem hiding this comment.
- bool "libtiff - Tagged Image File Format "
+ bool "libtiff: Tagged Image File Format"
| # | ||
| # THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY. | ||
| # |
There was a problem hiding this comment.
Please remove these lines. Please see this explanation as to why.
| # Original sources | ||
| ################################################################################ | ||
| LIBTIFF_VERSION=4.0.10 | ||
| LIBTIFF_URL=https://raw.githubusercontent.com/python-pillow/pillow-depends/master/tiff-$(LIBTIFF_VERSION).tar.gz |
There was a problem hiding this comment.
This is a weird place to retrieve the source from. Is there anywhere else more official?
Add Unikraft files for TIFF