fix(manifest): Better handling of Git and GitHub artifacts #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der` Signed-off-by: Alexander Jung <[email protected]>
This commit makes necessary adjustments to the `manifest` package to accommodate for users who wish to specify the Git SHA hash as the `version` attribute of a component. To make this adjustment a number of changes was necessary: - Propagating the Catalog's query of a version to each provider; - Allowing a quick-lookup of SHA on GitHub as an archive if `--use-git` is not provided; - Changing the "`git checkout`" mechanism to facilitate finding the hash amongst different branches. Signed-off-by: Alexander Jung <[email protected]>
nderjung
added
kind/fix
|
Still does not work with GitHub artifacts over ssh :( |
|
@nderjung I think this is the reason why you remember git SHAs working. Can you rebase this and we try it on staging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
This PR makes necessary adjustments to the
manifestpackage to better accommodate for users who wish to specify the Git SHA hash as theversionattribute of a component. To make this adjustment a number of changes were necessary:--use-gitis not provided;git checkout" mechanism to facilitate finding the hash amongst different branches.