-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for sr-SR #40
+3,011
−46
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3bfba9e
How to add a new language doc, adding sr_SR to the list.
nciric f2f1c36
Integrating patch from George and updating docs.
nciric 2a461e1
Small docs fix.
nciric b5425dc
Refine how_to_add_new_language.md
grhoten bd18e42
Update GrammarSynthesizerFactory.cpp
grhoten 529eb3d
Adding pointer to test lexicon in docs.
nciric 65e325d
Merge branch 'cira-sr' of https://github.com/unicode-org/inflection i…
nciric 280c591
Adding test data for Serbian.
nciric abe8a15
Adding new line to test files.
nciric 3bdd2f3
Merge remote-tracking branch 'origin/main' into cira-sr
nciric af02e3a
Adding files missed after the inflection rename.
nciric 8d1395a
Merge remote-tracking branch 'origin/main' into cira-sr
nciric 7549d7e
Fix local build after removal of CoreFoundations dep.
nciric 732bc56
Merge remote-tracking branch 'origin/main' into cira-sr
nciric a98f2e0
Merge remote-tracking branch 'origin/main' into cira-sr
nciric 4e775e4
Generating 150 nouns for Serbian lexicon. (#74)
nciric 4ad5425
Merge remote-tracking branch 'origin/main' into cira-sr
nciric 0ecb5d1
Adding dictionary and xml file and some code.
nciric 6c8e680
Switch count to number
grhoten 5a212ff
Switch count to number
grhoten 4f92d16
Add support for Serbian
grhoten 84fd8a1
Fix pronouns and tests before merge
nciric File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
1,039 changes: 1,039 additions & 0 deletions
1,039
inflection/resources/org/unicode/inflection/dictionary/dictionary_sr.lst
Large diffs are not rendered by default.
Oops, something went wrong.
803 changes: 803 additions & 0 deletions
803
inflection/resources/org/unicode/inflection/dictionary/inflectional_sr.xml
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
inflection/resources/org/unicode/inflection/inflection/pronoun_sr.csv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
оно,third,singular,nominative,neuter | ||
он,third,singular,nominative,masculine | ||
она,third,singular,nominative,feminine | ||
она,third,plural,nominative,neuter | ||
они,third,plural,nominative,masculine | ||
оне,third,plural,nominative,feminine | ||
ти,second,singular,nominative | ||
ви,second,plural,nominative | ||
ја,first,singular,nominative | ||
ми,first,plural,nominative | ||
њега,third,singular,accusative,neuter,stressed | ||
га,third,singular,accusative,neuter,unstressed | ||
њега,third,singular,accusative,masculine,stressed | ||
га,third,singular,accusative,masculine,unstressed | ||
њу,third,singular,accusative,feminine,stressed | ||
ју,third,singular,accusative,feminine,unstressed | ||
њих,third,plural,accusative,gender,stressed | ||
их,third,plural,accusative,gender,unstressed | ||
тебе,second,singular,accusative,stressed | ||
те,second,singular,accusative,unstressed | ||
вас,second,plural,accusative | ||
мене,first,singular,accusative,stressed | ||
ме,first,singular,accusative,unstressed | ||
нас,first,plural,accusative | ||
њему,third,singular,dative,neuter,stressed | ||
му,third,singular,dative,neuter,unstressed | ||
њему,third,singular,dative,masculine,stressed | ||
му,third,singular,dative,masculine,unstressed | ||
њој,third,singular,dative,feminine,stressed | ||
јој,third,singular,dative,feminine,unstressed | ||
њима,third,plural,dative,gender,stressed | ||
им,third,plural,dative,gender,unstressed | ||
теби,second,singular,dative,stressed | ||
ти,second,singular,dative,unstressed | ||
вама,second,plural,dative,stressed | ||
вам,second,plural,dative,unstressed | ||
мени,first,singular,dative,stressed | ||
ми,first,singular,dative,unstressed | ||
нама,first,plural,dative,stressed | ||
нам,first,plural,dative,unstressed | ||
њему,third,singular,locative,neuter | ||
њему,third,singular,locative,masculine | ||
њој,third,singular,locative,feminine | ||
њима,third,plural,locative,gender | ||
теби,second,singular,locative | ||
вама,second,plural,locative | ||
мени,first,singular,locative | ||
нама,first,plural,locative | ||
њим,third,singular,instrumental,neuter | ||
њим,third,singular,instrumental,masculine | ||
њом,third,singular,instrumental,feminine | ||
њима,third,plural,instrumental,gender | ||
тобом,second,singular,instrumental | ||
вама,second,plural,instrumental | ||
мном,first,singular,instrumental | ||
нама,first,plural,instrumental | ||
њега,third,singular,genitive,neuter,stressed | ||
га,third,singular,genitive,neuter,unstressed | ||
њега,third,singular,genitive,masculine,stressed | ||
га,third,singular,genitive,masculine,unstressed | ||
ње,third,singular,genitive,feminine,stressed | ||
је,third,singular,genitive,feminine,unstressed | ||
њих,third,plural,genitive,gender,stressed | ||
их,third,plural,genitive,gender,unstressed | ||
тебе,second,singular,genitive,stressed | ||
те,second,singular,genitive,unstressed | ||
вас,second,plural,genitive | ||
мене,first,singular,genitive,stressed | ||
ме,first,singular,genitive,unstressed | ||
нас,first,plural,genitive | ||
себе,person,number,gender,accusative,reflexive,stressed | ||
се,person,number,gender,accusative,reflexive,unstressed | ||
себи,person,number,gender,dative,reflexive,stressed | ||
си,person,number,gender,dative,reflexive,unstressed | ||
себе,person,number,gender,locative,reflexive | ||
собом,person,number,gender,instrumental,reflexive | ||
себи,person,number,gender,genitive,reflexive,stressed | ||
се,person,number,gender,genitive,reflexive,unstressed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
inflection/resources/org/unicode/inflection/tokenizer/config_sr.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# | ||
# Copyright 2024 and later: Unicode, Inc. and others. | ||
# License & terms of use: http://www.unicode.org/copyright.html | ||
# | ||
tokenizer.implementation.class=DefaultTokenizer |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
inflection/src/inflection/dialog/language/SrCommonConceptFactory.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* Copyright 2024 and later: Unicode, Inc. and others. | ||
* License & terms of use: http://www.unicode.org/copyright.html | ||
*/ | ||
#include <inflection/dialog/language/SrCommonConceptFactory.hpp> | ||
|
||
#include <inflection/dialog/SemanticFeatureConceptBase.hpp> | ||
#include <inflection/grammar/synthesis/GrammemeConstants.hpp> | ||
#include <inflection/npc.hpp> | ||
|
||
using inflection::grammar::synthesis::GrammemeConstants; | ||
|
||
namespace inflection::dialog::language { | ||
|
||
SrCommonConceptFactory::SrCommonConceptFactory(const ::inflection::util::ULocale &language) | ||
: super(language, ::inflection::grammar::synthesis::GrammemeConstants::GENDER, { | ||
{::inflection::grammar::synthesis::GrammemeConstants::GENDER_MASCULINE(), u"cardinal-masculine"}, | ||
{::inflection::grammar::synthesis::GrammemeConstants::GENDER_FEMININE(), u"cardinal-feminine"}, | ||
{::inflection::grammar::synthesis::GrammemeConstants::GENDER_NEUTER(), u"cardinal-neuter"}}) | ||
{ | ||
} | ||
|
||
SrCommonConceptFactory::~SrCommonConceptFactory() | ||
{ | ||
} | ||
|
||
} // namespace inflection::dialog::language |
21 changes: 21 additions & 0 deletions
21
inflection/src/inflection/dialog/language/SrCommonConceptFactory.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/* | ||
* Copyright 2024 and later: Unicode, Inc. and others. | ||
* License & terms of use: http://www.unicode.org/copyright.html | ||
*/ | ||
#pragma once | ||
|
||
#include <inflection/dialog/language/fwd.hpp> | ||
#include <inflection/dialog/CommonConceptFactoryImpl.hpp> | ||
|
||
class inflection::dialog::language::SrCommonConceptFactory | ||
: public CommonConceptFactoryImpl | ||
{ | ||
public: | ||
typedef CommonConceptFactoryImpl super; | ||
|
||
private: | ||
|
||
public: | ||
explicit SrCommonConceptFactory(const ::inflection::util::ULocale& language); | ||
~SrCommonConceptFactory() override; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
inflection/src/inflection/grammar/synthesis/SrGrammarSynthesizer.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/* | ||
* Copyright 2024 and later: Unicode, Inc. and others. | ||
* License & terms of use: http://www.unicode.org/copyright.html | ||
*/ | ||
#include <inflection/grammar/synthesis/SrGrammarSynthesizer.hpp> | ||
|
||
#include <inflection/dialog/DictionaryLookupFunction.hpp> | ||
#include <inflection/dialog/SemanticFeatureModel.hpp> | ||
#include <inflection/grammar/synthesis/GrammemeConstants.hpp> | ||
#include <inflection/grammar/synthesis/SrGrammarSynthesizer_SrDisplayFunction.hpp> | ||
#include <inflection/util/LocaleUtils.hpp> | ||
#include <inflection/npc.hpp> | ||
|
||
namespace inflection::grammar::synthesis { | ||
|
||
void SrGrammarSynthesizer::addSemanticFeatures(::inflection::dialog::SemanticFeatureModel& featureModel) | ||
{ | ||
featureModel.putDefaultFeatureFunctionByName(GrammemeConstants::GENDER, new ::inflection::dialog::DictionaryLookupFunction(::inflection::util::LocaleUtils::SERBIAN(), {GrammemeConstants::GENDER_MASCULINE(), GrammemeConstants::GENDER_FEMININE(), GrammemeConstants::GENDER_NEUTER()})); | ||
featureModel.putDefaultFeatureFunctionByName(GrammemeConstants::NUMBER, new ::inflection::dialog::DictionaryLookupFunction(::inflection::util::LocaleUtils::SERBIAN(), {GrammemeConstants::NUMBER_SINGULAR(), GrammemeConstants::NUMBER_PLURAL()})); | ||
|
||
featureModel.setDefaultDisplayFunction(new SrGrammarSynthesizer_SrDisplayFunction(featureModel)); | ||
} | ||
|
||
} // namespace inflection::grammar::synthesis |
19 changes: 19 additions & 0 deletions
19
inflection/src/inflection/grammar/synthesis/SrGrammarSynthesizer.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/* | ||
* Copyright 2024 and later: Unicode, Inc. and others. | ||
* License & terms of use: http://www.unicode.org/copyright.html | ||
*/ | ||
#pragma once | ||
|
||
#include <inflection/dialog/fwd.hpp> | ||
#include <inflection/grammar/synthesis/fwd.hpp> | ||
#include <string> | ||
#include <set> | ||
|
||
class inflection::grammar::synthesis::SrGrammarSynthesizer final | ||
{ | ||
public: | ||
static void addSemanticFeatures(::inflection::dialog::SemanticFeatureModel& featureModel); | ||
|
||
private: | ||
SrGrammarSynthesizer() = delete; | ||
}; |
64 changes: 64 additions & 0 deletions
64
inflection/src/inflection/grammar/synthesis/SrGrammarSynthesizer_SrDisplayFunction.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
/* | ||
* Copyright 2024 and later: Unicode, Inc. and others. | ||
* License & terms of use: http://www.unicode.org/copyright.html | ||
*/ | ||
#include <inflection/grammar/synthesis/SrGrammarSynthesizer_SrDisplayFunction.hpp> | ||
|
||
#include <inflection/tokenizer/TokenChain.hpp> | ||
#include <inflection/tokenizer/Tokenizer.hpp> | ||
#include <inflection/tokenizer/TokenizerFactory.hpp> | ||
#include <inflection/dialog/SemanticFeature.hpp> | ||
#include <inflection/dialog/SemanticFeatureModel.hpp> | ||
#include <inflection/dialog/SemanticFeatureModel_DisplayData.hpp> | ||
#include <inflection/dialog/DisplayValue.hpp> | ||
#include <inflection/grammar/synthesis/GrammemeConstants.hpp> | ||
#include <inflection/grammar/synthesis/GrammarSynthesizerUtil.hpp> | ||
#include <inflection/lang/StringFilterUtil.hpp> | ||
#include <inflection/util/LocaleUtils.hpp> | ||
#include <inflection/util/UnicodeSetUtils.hpp> | ||
#include <inflection/npc.hpp> | ||
#include <iterator> | ||
#include <memory> | ||
|
||
namespace inflection::grammar::synthesis { | ||
|
||
SrGrammarSynthesizer_SrDisplayFunction::SrGrammarSynthesizer_SrDisplayFunction(const ::inflection::dialog::SemanticFeatureModel& model) | ||
: super() | ||
, dictionary(*npc(::inflection::dictionary::DictionaryMetaData::createDictionary(::inflection::util::LocaleUtils::SERBIAN()))) | ||
, countFeature(model.getFeature(GrammemeConstants::NUMBER)) | ||
, genderFeature(model.getFeature(GrammemeConstants::GENDER)) | ||
, partOfSpeechFeature(model.getFeature(GrammemeConstants::POS)) | ||
, tokenizer(::inflection::tokenizer::TokenizerFactory::createTokenizer(::inflection::util::LocaleUtils::SERBIAN())) | ||
, dictionaryInflector(::inflection::util::LocaleUtils::SERBIAN(),{ | ||
{GrammemeConstants::POS_NOUN(), GrammemeConstants::POS_ADJECTIVE(), GrammemeConstants::POS_VERB()}, | ||
{GrammemeConstants::PERSON_THIRD(), GrammemeConstants::PERSON_FIRST(), GrammemeConstants::PERSON_SECOND()}, | ||
{GrammemeConstants::NUMBER_SINGULAR(), GrammemeConstants::NUMBER_PLURAL()}, | ||
{GrammemeConstants::GENDER_MASCULINE(), GrammemeConstants::GENDER_FEMININE(), GrammemeConstants::GENDER_NEUTER()} | ||
}, {}, true) | ||
{ | ||
} | ||
|
||
SrGrammarSynthesizer_SrDisplayFunction::~SrGrammarSynthesizer_SrDisplayFunction() | ||
{ | ||
} | ||
|
||
::inflection::dialog::DisplayValue * SrGrammarSynthesizer_SrDisplayFunction::getDisplayValue(const dialog::SemanticFeatureModel_DisplayData &displayData, const ::std::map<::inflection::dialog::SemanticFeature, ::std::u16string> &constraints, bool enableInflectionGuess) const | ||
{ | ||
const auto displayValue = GrammarSynthesizerUtil::getTheBestDisplayValue(displayData, constraints); | ||
if (displayValue == nullptr) { | ||
return nullptr; | ||
} | ||
::std::u16string displayString = displayValue->getDisplayString(); | ||
if (displayString.empty()) { | ||
return nullptr; | ||
} | ||
|
||
// To make compiler quiet about unused variable. | ||
if (enableInflectionGuess) | ||
return nullptr; | ||
|
||
// TODO Implement the rest | ||
return nullptr; | ||
} | ||
|
||
} // namespace inflection::grammar::synthesis |
42 changes: 42 additions & 0 deletions
42
inflection/src/inflection/grammar/synthesis/SrGrammarSynthesizer_SrDisplayFunction.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright 2024 and later: Unicode, Inc. and others. | ||
* License & terms of use: http://www.unicode.org/copyright.html | ||
*/ | ||
#pragma once | ||
|
||
#include <inflection/dialog/DefaultDisplayFunction.hpp> | ||
#include <inflection/dialog/DictionaryLookupInflector.hpp> | ||
#include <inflection/dictionary/fwd.hpp> | ||
#include <inflection/dictionary/Inflector.hpp> | ||
#include <inflection/grammar/synthesis/fwd.hpp> | ||
#include <inflection/tokenizer/Tokenizer.hpp> | ||
#include <string> | ||
#include <set> | ||
#include <vector> | ||
|
||
class inflection::grammar::synthesis::SrGrammarSynthesizer_SrDisplayFunction | ||
: public virtual ::inflection::dialog::DefaultDisplayFunction | ||
{ | ||
|
||
public: | ||
typedef ::inflection::dialog::DefaultDisplayFunction super; | ||
|
||
private: | ||
const ::inflection::dictionary::DictionaryMetaData& dictionary; | ||
const ::inflection::dialog::SemanticFeature* countFeature { }; | ||
const ::inflection::dialog::SemanticFeature* genderFeature { }; | ||
const ::inflection::dialog::SemanticFeature* partOfSpeechFeature { }; | ||
const ::std::unique_ptr<::inflection::tokenizer::Tokenizer> tokenizer; | ||
const ::inflection::dialog::DictionaryLookupInflector dictionaryInflector; | ||
|
||
public: | ||
::inflection::dialog::DisplayValue * getDisplayValue(const dialog::SemanticFeatureModel_DisplayData &displayData, const ::std::map<::inflection::dialog::SemanticFeature, ::std::u16string> &constraints, bool enableInflectionGuess) const override; | ||
|
||
public: | ||
explicit SrGrammarSynthesizer_SrDisplayFunction(const ::inflection::dialog::SemanticFeatureModel& model); | ||
~SrGrammarSynthesizer_SrDisplayFunction() override; | ||
|
||
public: | ||
SrGrammarSynthesizer_SrDisplayFunction(SrGrammarSynthesizer_SrDisplayFunction&) = delete; | ||
SrGrammarSynthesizer_SrDisplayFunction& operator=(const SrGrammarSynthesizer_SrDisplayFunction&) = delete; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
inflection/test/resources/inflection/dialog/inflection/sr.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<?xml version='1.0' encoding='utf-8'?> | ||
<!-- | ||
Copyright 2024 and later: Unicode, Inc. and others. | ||
License & terms of use: http://www.unicode.org/copyright.html | ||
--> | ||
<inflectionTest locale="sr"> | ||
<!-- Some nominative case tests where we don't expect changes --> | ||
<test><source case="nominative" number="singular">једро</source><result>једро</result></test> | ||
<test><source case="nominative" number="singular">жена</source><result>жена</result></test> | ||
<test><source case="nominative" number="singular">камен</source><result>камен</result></test> | ||
<test><source case="nominative" pos="proper-noun">Петар</source><result>Петар</result></test> | ||
</inflectionTest> |
25 changes: 25 additions & 0 deletions
25
inflection/test/resources/inflection/dialog/pronoun/sr.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?xml version='1.0' encoding='utf-8'?> | ||
<!-- | ||
Copyright 2024 and later: Unicode, Inc. and others. | ||
License & terms of use: http://www.unicode.org/copyright.html | ||
--> | ||
<inflectionTest locale="sr"> | ||
<!-- Simple inflection --> | ||
<test><source person="first" number="plural" case="nominative"/><result>ми</result></test> | ||
<test><source person="first" number="plural"/><result>ми</result></test> | ||
<test><source person="first" number="singular" case="nominative"/><result>ја</result></test> | ||
<test><source person="first" number="singular"/><result>ја</result></test> | ||
<test><source person="first"/><result>ја</result></test> | ||
<test><source person="second" number="plural" case="nominative"/><result>ви</result></test> | ||
<test><source person="second" number="singular" case="nominative"/><result>ти</result></test> | ||
<test><source person="third" number="plural" case="nominative"/><result>она</result></test> | ||
<test><source person="third" number="plural" gender="feminine" case="nominative"/><result>оне</result></test> | ||
<test><source person="third" number="plural" gender="masculine" case="nominative"/><result>они</result></test> | ||
<test><source person="third" number="plural" gender="neuter" case="nominative"/><result>она</result></test> | ||
<test><source person="third" number="singular" case="nominative"/><result>оно</result></test> | ||
<test><source person="third" number="singular" case="nominative"/><result>оно</result></test> | ||
<test><source person="third" number="singular" gender="feminine" case="nominative"/><result>она</result></test> | ||
<test><source person="third" number="singular" gender="masculine" case="nominative"/><result>он</result></test> | ||
<test><source person="third" number="singular" gender="neuter" case="nominative"/><result>оно</result></test> | ||
<test><source/><result>оно</result></test> | ||
</inflectionTest> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have plans to implement this TODO before merging this pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have some tests failing. My goal is to have tests pass, submit this PR, then open a new one with affecting only this file.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a good plan.