Audit icu_list markers #6073
Open
Audit icu_list markers #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth and
a team
as code owners
This is compelling to me. I think we can be consistent here and even perhaps have the registry check this. |
|
Writeup of my position on namespaces: #4991 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think these should be
AndV2,OrV2, andUnitV2, in some kind of "list" namespace that is not part of the marker name. @sffc has mentioned he wants to haveSymbolsV1in multiple components, but I think the component name space should be part of the marker. We definitely have instances of using data markers across crates, and this will put us in a situation of a constructor requiring two differentSymbolsV1markers, which will lead to confusing docs and confusing code.I think the policy should be that the first word of the marker name is the component.