Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read Units Data from CLDR #4660

Merged
merged 23 commits into from
May 29, 2024
Merged

Read Units Data from CLDR #4660

merged 23 commits into from
May 29, 2024

Conversation

younies
Copy link
Member

@younies younies commented Mar 7, 2024 •
edited

No description provided.

@younies younies marked this pull request as draft March 7, 2024 10:08
sffc
sffc reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLDR data add looks good. I think we should sketch out the initial data struct before merging this.

@younies younies changed the title Implement DataModule for short and narrow units formatter Introduce DataModule for Short&Narrow Unit Formatting Mar 17, 2024
@younies younies changed the title Introduce DataModule for Short&Narrow Unit Formatting Introduce DataModule for Basic Units Formatting Mar 20, 2024
@younies younies changed the title Introduce DataModule for Basic Units Formatting Introduce DataModule for Units Formatting May 15, 2024
robertbastian
robertbastian reviewed May 28, 2024
View reviewed changes
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@younies younies changed the title Introduce DataModule for Units Formatting Read Units Data from CLDR May 28, 2024
@younies younies closed this May 28, 2024
@younies
Copy link
Member Author

younies commented May 28, 2024

CLDR data add looks good. I think we should sketch out the initial data struct before merging this.

Shall we just merge this and make the new PR focussing on the data structure ?

@younies younies reopened this May 28, 2024
@younies younies marked this pull request as ready for review May 28, 2024 15:46
@younies younies requested a review from sffc May 28, 2024 15:46
sffc
sffc previously approved these changes May 28, 2024
View reviewed changes
@sffc
Copy link
Member

sffc commented May 28, 2024

This PR adds CLDR JSON files without using them; I think I prefer landing data structs first, but this is fine if it helps

The PR has 17 commits with 9 merge commits and a bunch of other commits that appear to be obsolete

@younies younies requested review from robertbastian and sffc and removed request for Manishearth May 29, 2024 08:27
@younies younies merged commit 60fa20a into unicode-org:main May 29, 2024
30 checks passed
@younies younies deleted the impl-units-short-narrow-data branch May 29, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@robertbastian robertbastian Awaiting requested review from robertbastian robertbastian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@younies @sffc @robertbastian