Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-23040 Migrate the javadoc taglets away from the JDK 8 APIs #3444

Merged
merged 4 commits into from
Mar 24, 2025
Merged

ICU-23040 Migrate the javadoc taglets away from the JDK 8 APIs #3444

merged 4 commits into from
Mar 24, 2025

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Mar 20, 2025 •
edited
Loading

Checklist

  • Required: Issue filed: ICU-23040
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

mihnita added 3 commits March 19, 2025 11:29
@mihnita
ICU-23040 Move taglets to their own artifact
acff92b
@mihnita
ICU-23040 Extract inner classes as standalone
04ca9bc
@mihnita
ICU-23040 The real move from the JDK 8 APIs
6fcbd48 
ICUIgnoreTaglet was split in 3: ICUBugTaglet, ICUCategoryTaglet, ICUSummaryTaglet
because there is no more registration, should be one taglet per class.

Also moved making the Category a proper taglet.
@mihnita
Copy link
Contributor Author

mihnita commented Mar 20, 2025

The javadoc generated with JDK 11 and the new taglets is here: https://mihai-nita.net/tmp/jdoc11

Compare to the released version: https://unicode-org.github.io/icu-docs/apidoc/released/icu4j/

I've split this into several commits that I hope will make the review easier, and help git keep the history.

@mihnita mihnita requested review from macchiati and markusicu March 20, 2025 00:36
@mihnita mihnita force-pushed the mihai-jdk11-taglets branch from 83ba972 to 82fef52 Compare March 20, 2025 00:47
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4j/stylesheet8.css is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita requested a review from yumaoka March 20, 2025 18:33
@mihnita
Copy link
Contributor Author

mihnita commented Mar 24, 2025

Thank you!
M

@mihnita mihnita merged commit dcff47f into unicode-org:main Mar 24, 2025
15 checks passed
@mihnita mihnita deleted the mihai-jdk11-taglets branch March 25, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@macchiati macchiati Awaiting requested review from macchiati

@yumaoka yumaoka Awaiting requested review from yumaoka

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihnita @markusicu