Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to Dart #402

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Small fixes to Dart #402

wants to merge 5 commits into from

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented Mar 4, 2025 •
edited
Loading

Fix implicit call to toJson and run dart pub upgrade --major-versions for dart_native and dart_web

@sven-oly sven-oly self-assigned this Mar 5, 2025
sven-oly
sven-oly reviewed Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@sven-oly sven-oly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks OK, but I'm having trouble running the bash jobs locally, withall Dart tests reporting "Error" or "Not supported".

sven-oly
sven-oly approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@sven-oly sven-oly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll approve. Let's see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven-oly sven-oly sven-oly approved these changes

Assignees

@sven-oly sven-oly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosuem @sven-oly