Add sys.exit(1) on failures #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeran
reviewed
Jan 14, 2025
| @@ -126,7 +126,8 @@ def main(args): | |||
| len(schema_errors), schema_count) | |||
| for failure in schema_errors: | |||
| logging.error(' %s', failure) | |||
| exit(1) | |||
| # We need to clobber the process | |||
| sys.exit(1) | |||
| else: | |||
| logging.info("All %d schema are valid in file %s", schema_count, output_filename) | |||
| exit(0) | |||
There was a problem hiding this comment.
You didn't change this line. But I wonder if you need it.
There was a problem hiding this comment.
I think sys.exit is appropriate here.
schema/check_generated_data.py
Outdated
| else: | ||
| logging.info("All %d generated test data files match with schema", schema_count) | ||
| exit(0) | ||
| sys.exit(0) |
There was a problem hiding this comment.
Do you need a sys.exit(0)? If this is the last line of the happy case, then it reads better to remove the line. When I see sys.exit(<nonzero>), I assume that someone is signalling an unnaturally early exit, so a really unhappy case. Happy cases and handled unhappy cases would otherwise be treated "normally" (no op, try/catch exception handling, etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.