Add MessageFormat2 support with ICU4J executor #175
Conversation
|
Thanks for your work on this. I look forward to integrating MF2! |
mradbourne
changed the title
mradbourne
force-pushed
the
messageformat2-icu4j
branch
from
b11be59
to
9066446
Compare
testgen/testdata_gen.py
Outdated
|
|
||
| # Utility functions | ||
| def computeMaxDigitsForCount(count): | ||
| return math.ceil(math.log10(count + 1)) | ||
|
|
||
|
|
||
| def readFile(filename, version=''): | ||
| def readFile(filename, version='', filetype='txt'): |
There was a problem hiding this comment.
How does Python allow people to attach doc strings for methods? Can you add a source doc string to document filetype as having special behavior when you provide a value in the set of ['json']?
This reverts commit b524cbc.
…t formatting behavior
mradbourne
force-pushed
the
messageformat2-icu4j
branch
from
7b4c9f4
to
1bb65d5
Compare
|
FYI, the current failure in the end-to-end job in CI is related to a configuration mistake in the Dart intl4x library that has been fixed and should roll out soon. It's obviously unrelated to our work, so ignore it for now. |
| "value": 1.2 | ||
| } | ||
| ], | ||
| "verify": "=1.2" |
There was a problem hiding this comment.
I predict this test expected value is not correct and will need changing, once we get the test data hooked up to the executor. Plural selection happens on the "formatted" number (more precisely: the formatted-to-parts result, which comes after rounding is performed, notation changes applied, units are added, etc.), not the input number. I would expect the result to be other.
By contrast, the previous test case's expected value seems fine, since 1.2 :integer -> 1 (formatted) -> ONE plural category (selection on formatted value).
| "value": 1.2 | ||
| } | ||
| ], | ||
| "verify": "=1.2" |
There was a problem hiding this comment.
Ditto, but double problem: formatting should return 1. The matching ought not to happen on the localized formatted string, but even if it did, the resulting string would be =1,2, right? Also, does our syntax support , in a number literal? It doesn't seem so.
| "description": "", | ||
| "tests": [ | ||
| ] | ||
| } |
There was a problem hiding this comment.
is this file proper JSON? the object that begins on line 1 ends on line 6.
beyond that, this file and some others that follow don't specify the default locale, FYI.
No description provided.