Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payment plan refactor #4597

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from
Draft

payment plan refactor #4597

wants to merge 29 commits into from

Conversation

MarekBiczysko
Copy link
Contributor

@MarekBiczysko MarekBiczysko commented Jan 28, 2025

@MarekBiczysko MarekBiczysko marked this pull request as draft January 28, 2025 14:10
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 74.90040% with 63 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (5fec700) to head (bba8273).

Files with missing lines Patch % Lines
src/hct_mis_api/apps/payment/admin.py 56.52% 20 Missing ⚠️
...t_mis_api/apps/payment/services/payment_gateway.py 69.44% 11 Missing ⚠️
...api/apps/payment/services/payment_plan_services.py 73.17% 11 Missing ⚠️
..._mis_api/apps/payment/migrations/0014_migration.py 54.54% 10 Missing ⚠️
src/hct_mis_api/apps/payment/models/payment.py 80.00% 10 Missing ⚠️
src/hct_mis_api/apps/payment/schema.py 96.15% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (74.90%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4597      +/-   ##
===========================================
- Coverage    85.31%   85.01%   -0.31%     
===========================================
  Files          539      541       +2     
  Lines        36736    36692      -44     
===========================================
- Hits         31342    31193     -149     
- Misses        5394     5499     +105     
Flag Coverage Δ
e2e 59.88% <41.03%> (-0.87%) ⬇️
unittests 83.44% <74.10%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants